fix(core): restore dind test #920
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 77.71% 78.70% +0.98%
==========================================
Files 14 14
Lines 1216 1216
Branches 142 142
==========================================
+ Hits 945 957 +12
+ Misses 231 218 -13
- Partials 40 41 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexanderankin
force-pushed
the
fix/ci-test
branch
from
6368202 to
53b8e3d
Compare
Member
Author
|
@CarliJoy thoughts before i merge? |
Tranquility2
approved these changes
Jan 24, 2026
Contributor
|
LGTM. I am not sure that we require logger output within tests instead of simple print. But this is a question of taste. |
Member
Author
|
closing in favor of #960 |
alexanderankin
pushed a commit
that referenced
this pull request
Feb 4, 2026
This PR removes poetry and replaces it with uv. Also: - remove not required pyproject.toml/requirement.txt/setup.py files -> everything is kept in one pyproject.toml and common lock file - remove not required Dockerfile for docs. uv run just works fine here - keep license file in release (it is good) closes #957 Note: This PR is based on #920 in order to have a working CI/CD Review notes: - Locally build packages once in main and once in this branch. - Compare the results. - Test make endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally pushed this code in the previous commit, this PR associates itself with the change so the git history makes sense later. as well as fix the bug